Remove unused SimpleBtMessage::getMessageLength

src/BtBitfieldMessage.cc

@@ -113,8 +113,6 @@ std::vector<unsigned char> BtBitfieldMessage::createMessage()
   return msg;
 }
 
-size_t BtBitfieldMessage::getMessageLength() { return 5 + bitfieldLength_; }
-
 std::string BtBitfieldMessage::toString() const
 {
   std::string s = NAME;

src/BtBitfieldMessage.h

@@ -68,8 +68,6 @@ public:
 
   virtual std::vector<unsigned char> createMessage() CXX11_OVERRIDE;
 
-  virtual size_t getMessageLength() CXX11_OVERRIDE;
-
   virtual std::string toString() const CXX11_OVERRIDE;
 };
 

src/BtExtendedMessage.cc

@@ -78,14 +78,6 @@ std::vector<unsigned char> BtExtendedMessage::createMessage()
   return msg;
 }
 
-size_t BtExtendedMessage::getMessageLength()
-{
-  if (!msgLength_) {
-    msgLength_ = 6 + extensionMessage_->getPayload().size();
-  }
-  return msgLength_;
-}
-
 bool BtExtendedMessage::sendPredicate() const
 {
   return getPeer()->isExtendedMessagingEnabled();

src/BtExtendedMessage.h

@@ -63,8 +63,6 @@ public:
 
   virtual std::vector<unsigned char> createMessage() CXX11_OVERRIDE;
 
-  virtual size_t getMessageLength() CXX11_OVERRIDE;
-
   virtual bool sendPredicate() const CXX11_OVERRIDE;
 
   virtual std::string toString() const CXX11_OVERRIDE;

src/BtHandshakeMessage.cc

@@ -93,8 +93,6 @@ std::vector<unsigned char> BtHandshakeMessage::createMessage()
   return msg;
 }
 
-size_t BtHandshakeMessage::getMessageLength() { return MESSAGE_LENGTH; }
-
 std::string BtHandshakeMessage::toString() const
 {
   return fmt("%s peerId=%s, reserved=%s", NAME,

src/BtHandshakeMessage.h

@@ -81,8 +81,6 @@ public:
 
   virtual std::vector<unsigned char> createMessage() CXX11_OVERRIDE;
 
-  virtual size_t getMessageLength() CXX11_OVERRIDE;
-
   virtual std::string toString() const CXX11_OVERRIDE;
 
   bool isFastExtensionSupported() const;

src/BtKeepAliveMessage.cc

@@ -48,6 +48,4 @@ std::vector<unsigned char> BtKeepAliveMessage::createMessage()
   return std::vector<unsigned char>(MESSAGE_LENGTH);
 }
 
-size_t BtKeepAliveMessage::getMessageLength() { return MESSAGE_LENGTH; }
-
 } // namespace aria2

src/BtKeepAliveMessage.h

@@ -54,8 +54,6 @@ public:
 
   virtual std::vector<unsigned char> createMessage() CXX11_OVERRIDE;
 
-  virtual size_t getMessageLength() CXX11_OVERRIDE;
-
   virtual std::string toString() const CXX11_OVERRIDE { return NAME; }
 };
 

src/BtPortMessage.cc

@@ -114,8 +114,6 @@ std::vector<unsigned char> BtPortMessage::createMessage()
   return msg;
 }
 
-size_t BtPortMessage::getMessageLength() { return MESSAGE_LENGTH; }
-
 std::string BtPortMessage::toString() const
 {
   return fmt("%s port=%u", NAME, port_);

src/BtPortMessage.h

@@ -73,8 +73,6 @@ public:
 
   virtual std::vector<unsigned char> createMessage() CXX11_OVERRIDE;
 
-  virtual size_t getMessageLength() CXX11_OVERRIDE;
-
   virtual std::string toString() const CXX11_OVERRIDE;
 
   void setLocalNode(DHTNode* localNode);

src/IndexBtMessage.cc

@@ -53,8 +53,6 @@ std::vector<unsigned char> IndexBtMessage::createMessage()
   return msg;
 }
 
-size_t IndexBtMessage::getMessageLength() { return MESSAGE_LENGTH; }
-
 std::string IndexBtMessage::toString() const
 {
   return fmt("%s index=%lu", getName(), static_cast<unsigned long>(index_));

src/IndexBtMessage.h

@@ -67,8 +67,6 @@ public:
 
   virtual std::vector<unsigned char> createMessage() CXX11_OVERRIDE;
 
-  virtual size_t getMessageLength() CXX11_OVERRIDE;
-
   virtual std::string toString() const CXX11_OVERRIDE;
 };
 

src/RangeBtMessage.cc

@@ -63,8 +63,6 @@ std::vector<unsigned char> RangeBtMessage::createMessage()
   return msg;
 }
 
-size_t RangeBtMessage::getMessageLength() { return MESSAGE_LENGTH; }
-
 std::string RangeBtMessage::toString() const
 {
   return fmt("%s index=%lu, begin=%d, length=%d", getName(),

src/RangeBtMessage.h

@@ -77,8 +77,6 @@ public:
 
   virtual std::vector<unsigned char> createMessage() CXX11_OVERRIDE;
 
-  virtual size_t getMessageLength() CXX11_OVERRIDE;
-
   virtual std::string toString() const CXX11_OVERRIDE;
 };
 

src/SimpleBtMessage.cc

@@ -57,7 +57,6 @@ void SimpleBtMessage::send()
                   getPeer()->getIPAddress().c_str(), getPeer()->getPort(),
                   toString().c_str()));
   auto msg = createMessage();
-  size_t msgLength = getMessageLength();
   A2_LOG_DEBUG(
       fmt("msglength = %lu bytes", static_cast<unsigned long>(msg.size())));
   getPeerConnection()->pushBytes(std::move(msg), getProgressUpdate());

src/SimpleBtMessage.h

@@ -51,8 +51,6 @@ public:
 
   virtual std::vector<unsigned char> createMessage() = 0;
 
-  virtual size_t getMessageLength() = 0;
-
   virtual std::unique_ptr<ProgressUpdate> getProgressUpdate();
 
   virtual bool sendPredicate() const { return true; };

src/ZeroBtMessage.cc

@@ -54,8 +54,6 @@ std::vector<unsigned char> ZeroBtMessage::createMessage()
   return msg;
 }
 
-size_t ZeroBtMessage::getMessageLength() { return MESSAGE_LENGTH; }
-
 std::string ZeroBtMessage::toString() const { return getName(); }
 
 } // namespace aria2

src/ZeroBtMessage.h

@@ -58,8 +58,6 @@ public:
 
   virtual std::vector<unsigned char> createMessage() CXX11_OVERRIDE;
 
-  virtual size_t getMessageLength() CXX11_OVERRIDE;
-
   virtual std::string toString() const CXX11_OVERRIDE;
 };
 

test/BtBitfieldMessageTest.cc

@@ -79,7 +79,6 @@ void BtBitfieldMessageTest::testCreateMessage()
   auto rawmsg = msg.createMessage();
   CPPUNIT_ASSERT_EQUAL((size_t)7, rawmsg.size());
   CPPUNIT_ASSERT(std::equal(std::begin(rawmsg), std::end(rawmsg), data));
-  CPPUNIT_ASSERT_EQUAL((size_t)7, msg.getMessageLength());
 }
 
 void BtBitfieldMessageTest::testDoReceivedAction()

test/BtExtendedMessageTest.cc

@@ -81,7 +81,6 @@ void BtExtendedMessageTest::testCreateMessage()
   auto rawmsg = msg.createMessage();
   CPPUNIT_ASSERT_EQUAL((size_t)17, rawmsg.size());
   CPPUNIT_ASSERT(std::equal(std::begin(rawmsg), std::end(rawmsg), data));
-  CPPUNIT_ASSERT_EQUAL((size_t)17, msg.getMessageLength());
 }
 
 void BtExtendedMessageTest::testDoReceivedAction()

test/BtKeepAliveMessageTest.cc

@@ -27,7 +27,6 @@ void BtKeepAliveMessageTest::testCreateMessage()
   memset(data, 0, sizeof(data));
   BtKeepAliveMessage message;
   CPPUNIT_ASSERT_EQUAL((uint8_t)99, message.getId());
-  CPPUNIT_ASSERT_EQUAL((size_t)4, message.getMessageLength());
   auto rawmsg = message.createMessage();
   CPPUNIT_ASSERT_EQUAL((size_t)4, rawmsg.size());
   CPPUNIT_ASSERT(std::equal(std::begin(rawmsg), std::end(rawmsg), data));