2010-05-08 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>

	Return const reference.
	* src/DefaultPieceStorage.h
	* src/DownloadContext.h
	* src/FeatureConfig.cc
	* src/FeatureConfig.h
	* src/OptionParser.cc
	* src/OptionParser.h
	* src/SimpleRandomizer.cc
	* src/SimpleRandomizer.h

ChangeLog

@@ -1,3 +1,15 @@
+2010-05-08  Tatsuhiro Tsujikawa  <t-tujikawa@users.sourceforge.net>
+
+	Return const reference.
+	* src/DefaultPieceStorage.h
+	* src/DownloadContext.h
+	* src/FeatureConfig.cc
+	* src/FeatureConfig.h
+	* src/OptionParser.cc
+	* src/OptionParser.h
+	* src/SimpleRandomizer.cc
+	* src/SimpleRandomizer.h
+
 2010-05-07  Tatsuhiro Tsujikawa  <t-tujikawa@users.sourceforge.net>
 
 	Bump up version number to 1.9.3.

src/DefaultPieceStorage.h

@@ -243,7 +243,7 @@ public:
     _pieceSelector = pieceSelector;
   }
 
-  SharedHandle<PieceSelector> getPieceSelector() const
+  const SharedHandle<PieceSelector>& getPieceSelector() const
   {
     return _pieceSelector;
   }

src/DownloadContext.h

@@ -201,7 +201,7 @@ public:
 
   void setDir(const std::string& dir) { _dir = dir; }
 
-  SharedHandle<Signature> getSignature() const { return _signature; }
+  const SharedHandle<Signature>& getSignature() const { return _signature; }
 
   void setSignature(const SharedHandle<Signature>& signature)
   {

src/FeatureConfig.cc

@@ -120,7 +120,7 @@ FeatureConfig::FeatureConfig() {
   _features.insert(vbegin(featureArray), vend(featureArray));
 }
 
-SharedHandle<FeatureConfig> FeatureConfig::getInstance()
+const SharedHandle<FeatureConfig>& FeatureConfig::getInstance()
 {
   if(_featureConfig.isNull()) {
     _featureConfig.reset(new FeatureConfig());

src/FeatureConfig.h

@@ -56,7 +56,7 @@ private:
 
   FeatureConfig();
 public:
-  static SharedHandle<FeatureConfig> getInstance();
+  static const SharedHandle<FeatureConfig>& getInstance();
 
   uint16_t getDefaultPort(const std::string& protocol) const;
 

src/OptionParser.cc

@@ -369,7 +369,7 @@ SharedHandle<OptionHandler> OptionParser::findByShortName(char shortName) const
 
 SharedHandle<OptionParser> OptionParser::_optionParser;
 
-SharedHandle<OptionParser> OptionParser::getInstance()
+const SharedHandle<OptionParser>& OptionParser::getInstance()
 {
   if(_optionParser.isNull()) {
     _optionParser.reset(new OptionParser());

src/OptionParser.h

@@ -101,7 +101,7 @@ public:
   // Hidden options are not returned.
   SharedHandle<OptionHandler> findByShortName(char shortName) const;
 
-  static SharedHandle<OptionParser> getInstance();
+  static const SharedHandle<OptionParser>& getInstance();
 };
 
 typedef SharedHandle<OptionParser> OptionParserHandle;

src/SimpleRandomizer.cc

@@ -42,7 +42,7 @@ namespace aria2 {
 
 SharedHandle<SimpleRandomizer> SimpleRandomizer::_randomizer;
 
-SharedHandle<SimpleRandomizer> SimpleRandomizer::getInstance()
+const SharedHandle<SimpleRandomizer>& SimpleRandomizer::getInstance()
 {
   if(_randomizer.isNull()) {
     _randomizer.reset(new SimpleRandomizer());

src/SimpleRandomizer.h

@@ -46,7 +46,7 @@ private:
   SimpleRandomizer();
 public:
   
-  static SharedHandle<SimpleRandomizer> getInstance();
+  static const SharedHandle<SimpleRandomizer>& getInstance();
   
   static void init();