Browse Source

2010-06-13 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>

	Made DHTMessageEntry struct
	* src/DHTMessageDispatcherImpl.cc
	* src/DHTMessageDispatcherImpl.h
	* src/DHTMessageEntry.cc
	* src/DHTMessageEntry.h
Tatsuhiro Tsujikawa 15 years ago
parent
commit
411f818032
5 changed files with 38 additions and 26 deletions
  1. 8 0
      ChangeLog
  2. 18 14
      src/DHTMessageDispatcherImpl.cc
  3. 1 1
      src/DHTMessageDispatcherImpl.h
  4. 7 6
      src/DHTMessageEntry.cc
  5. 4 5
      src/DHTMessageEntry.h

+ 8 - 0
ChangeLog

@@ -1,3 +1,11 @@
+2010-06-13  Tatsuhiro Tsujikawa  <t-tujikawa@users.sourceforge.net>
+
+	Made DHTMessageEntry struct
+	* src/DHTMessageDispatcherImpl.cc
+	* src/DHTMessageDispatcherImpl.h
+	* src/DHTMessageEntry.cc
+	* src/DHTMessageEntry.h
+
 2010-06-13  Tatsuhiro Tsujikawa  <t-tujikawa@users.sourceforge.net>
 
 	Made DHTNodeLookupEntry struct

+ 18 - 14
src/DHTMessageDispatcherImpl.cc

@@ -55,44 +55,48 @@ DHTMessageDispatcherImpl::DHTMessageDispatcherImpl
 DHTMessageDispatcherImpl::~DHTMessageDispatcherImpl() {}
 
 void
-DHTMessageDispatcherImpl::addMessageToQueue(const SharedHandle<DHTMessage>& message,
-                                            time_t timeout,
-                                            const SharedHandle<DHTMessageCallback>& callback)
+DHTMessageDispatcherImpl::addMessageToQueue
+(const SharedHandle<DHTMessage>& message,
+ time_t timeout,
+ const SharedHandle<DHTMessageCallback>& callback)
 {
-  SharedHandle<DHTMessageEntry> e(new DHTMessageEntry(message, timeout, callback));
+  SharedHandle<DHTMessageEntry> e
+    (new DHTMessageEntry(message, timeout, callback));
   _messageQueue.push_back(e);
 }
 
 void
-DHTMessageDispatcherImpl::addMessageToQueue(const SharedHandle<DHTMessage>& message,
-                                            const SharedHandle<DHTMessageCallback>& callback)
+DHTMessageDispatcherImpl::addMessageToQueue
+(const SharedHandle<DHTMessage>& message,
+ const SharedHandle<DHTMessageCallback>& callback)
 {
   addMessageToQueue(message, _timeout, callback);
 }
 
 bool
-DHTMessageDispatcherImpl::sendMessage(const SharedHandle<DHTMessageEntry>& entry)
+DHTMessageDispatcherImpl::sendMessage
+(const SharedHandle<DHTMessageEntry>& entry)
 {
   try {
-    if(entry->_message->send()) {
-      if(!entry->_message->isReply()) {
-        _tracker->addMessage(entry->_message, entry->_timeout, entry->_callback);
+    if(entry->message->send()) {
+      if(!entry->message->isReply()) {
+        _tracker->addMessage(entry->message, entry->timeout, entry->callback);
       }
       if(_logger->info()) {
-        _logger->info("Message sent: %s", entry->_message->toString().c_str());
+        _logger->info("Message sent: %s", entry->message->toString().c_str());
       }
     } else {
       return false;
     }
   } catch(RecoverableException& e) {
     _logger->info("Failed to send message: %s",
-                  e, entry->_message->toString().c_str());
+                  e, entry->message->toString().c_str());
     // Add message to DHTMessageTracker with timeout 0 to treat it as
     // time out. Without this, we have untracked message and some of
     // DHTTask(such as DHTAbstractNodeLookupTask) don't finish
     // forever.
-    if(!entry->_message->isReply()) {
-      _tracker->addMessage(entry->_message, 0, entry->_callback);
+    if(!entry->message->isReply()) {
+      _tracker->addMessage(entry->message, 0, entry->callback);
     }
   }
   return true;

+ 1 - 1
src/DHTMessageDispatcherImpl.h

@@ -41,7 +41,7 @@
 namespace aria2 {
 
 class DHTMessageTracker;
-class DHTMessageEntry;
+struct DHTMessageEntry;
 class Logger;
 
 class DHTMessageDispatcherImpl:public DHTMessageDispatcher {

+ 7 - 6
src/DHTMessageEntry.cc

@@ -39,12 +39,13 @@
 
 namespace aria2 {
 
-DHTMessageEntry::DHTMessageEntry(const SharedHandle<DHTMessage>& message,
-                                 time_t timeout,
-                                 const SharedHandle<DHTMessageCallback>& callback):
-  _message(message),
-  _timeout(timeout),
-  _callback(callback) {}
+DHTMessageEntry::DHTMessageEntry
+(const SharedHandle<DHTMessage>& message,
+ time_t timeout,
+ const SharedHandle<DHTMessageCallback>& callback):
+  message(message),
+  timeout(timeout),
+  callback(callback) {}
 
 DHTMessageEntry::~DHTMessageEntry() {}
 

+ 4 - 5
src/DHTMessageEntry.h

@@ -44,11 +44,10 @@ namespace aria2 {
 class DHTMessage;
 class DHTMessageCallback;
 
-class DHTMessageEntry {
-public:
-  SharedHandle<DHTMessage> _message;
-  time_t _timeout;
-  SharedHandle<DHTMessageCallback> _callback;
+struct DHTMessageEntry {
+  SharedHandle<DHTMessage> message;
+  time_t timeout;
+  SharedHandle<DHTMessageCallback> callback;
 
   DHTMessageEntry(const SharedHandle<DHTMessage>& message,
                   time_t timeout,