Browse Source

2009-05-05 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>

	Applied Pascal Bleser's patch: increases MAX_RECV_BUFFER for ftp
	from 4096 to 65536 (for insanely large ftp login banners)
	* src/FtpConnection.h
	* test/FtpConnectionTest.cc
Tatsuhiro Tsujikawa 16 years ago
parent
commit
3511aad188
3 changed files with 10 additions and 2 deletions
  1. 7 0
      ChangeLog
  2. 2 1
      src/FtpConnection.h
  3. 1 1
      test/FtpConnectionTest.cc

+ 7 - 0
ChangeLog

@@ -1,3 +1,10 @@
+2009-05-05  Tatsuhiro Tsujikawa  <t-tujikawa@users.sourceforge.net>
+
+	Applied Pascal Bleser's patch: increases MAX_RECV_BUFFER for ftp
+	from 4096 to 65536 (for insanely large ftp login banners)
+	* src/FtpConnection.h
+	* test/FtpConnectionTest.cc
+	
 2009-05-05  Tatsuhiro Tsujikawa  <t-tujikawa@users.sourceforge.net>
 
 	In DefaultBtContext::getActualBasePath(), return first

+ 2 - 1
src/FtpConnection.h

@@ -79,7 +79,8 @@ private:
 
   static const std::string I;
 
-  static const size_t MAX_RECV_BUFFER = 4096;
+  //prepare for large banners
+  static const size_t MAX_RECV_BUFFER = 65536;
 public:
   FtpConnection(int32_t cuid, const SharedHandle<SocketCore>& socket,
 		const SharedHandle<Request>& req,

+ 1 - 1
test/FtpConnectionTest.cc

@@ -195,7 +195,7 @@ void FtpConnectionTest::testReceiveResponse_overflow()
   char data[1024];
   memset(data, 0, sizeof(data));
   memcpy(data, "213 ", 4);
-  for(int i = 0; i < 4; ++i) {
+  for(int i = 0; i < 64; ++i) {
     _serverSocket->writeData(data, sizeof(data));
     waitRead(_clientSocket);
     CPPUNIT_ASSERT_EQUAL((unsigned int)0, _ftp->receiveResponse());